Skip to content

fix: exclude for const/let in/of decl from hoisted decls#14287

Open
swwind wants to merge 3 commits into
mainfrom
fix/14274
Open

fix: exclude for const/let in/of decl from hoisted decls#14287
swwind wants to merge 3 commits into
mainfrom
fix/14274

Conversation

@swwind

@swwind swwind commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary

fixes #14274

There is missing matches!(var_decl.kind, VarDeclKind::Var) when checking if var decl inside for in/of loop.

Old: for (const x in array) {} => var x

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions

github-actions Bot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 7827c0d to fix: apply global overrideStrict for ContextModule (#14361) by Qingyu Wang

🙈 Size remains the same at 62.67MB

@github-actions

github-actions Bot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Gzip Size Change Gzip Change
popular-libs 1.7 MB 551.3 KB 0 0
react-10k 5.6 MB 1.3 MB 0 0
react-1k 822.8 KB 218.3 KB 0 0
ui-components 4.8 MB 1.4 MB 0 0
react-5k 2.7 MB 669.1 KB 0 0

Generated by Rsdoctor GitHub Action

@codspeed-hq

codspeed-hq Bot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merging this PR will improve performance by 3.92%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 51 untouched benchmarks
⏩ 36 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation rust@persistent_cache_restore_after_single_file_change@basic-react-development 14.9 ms 14.3 ms +3.92%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing fix/14274 (7827c0d) with main (b2b2500)

Open in CodSpeed

Footnotes

  1. 36 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@chenjiahan chenjiahan requested a review from LingyuCoder June 8, 2026 03:20
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploying rspack with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7827c0d
Status: ✅  Deploy successful!
Preview URL: https://14064c9e.rspack-v2.pages.dev
Branch Preview URL: https://fix-14274.rspack-v2.pages.dev

View logs

@chenjiahan chenjiahan requested a review from CPunisher June 12, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LingyuCoder LingyuCoder Awaiting requested review from LingyuCoder

@CPunisher CPunisher Awaiting requested review from CPunisher

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: dead code elimination produces variable name conflicts

1 participant

@swwind